Workaround Integer detection for ruby 2.4 onward#31
Open
bootleq wants to merge 1 commit intopascal-za:masterfrom
Open
Workaround Integer detection for ruby 2.4 onward#31bootleq wants to merge 1 commit intopascal-za:masterfrom
bootleq wants to merge 1 commit intopascal-za:masterfrom
Conversation
We used to detect field definition `foo 42` by ask the class name of 42, which was `Fixnum` before ruby 2.4, but now `Integer`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Ruby 2.4 unifies Fixnum and Bignum into Integer, a field definition
foo: 100previously map to migrant'sDataType::Fixnum(by asking100.class.name) will incorrectly change toInteger < Bignum.This will cause many differences detected, and produce migration files to add
limit => 8and might removedefault => nilto integer fields.